Add maven local by default in order to test local build (especially for Apache Iceberg) #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or Apache Iceberg)
jbonofre
requested review from
ashvina,
RussellSpitzer,
snazy,
vvcephei,
takidau and
jackye1995
as code owners
snazy
requested changes
Sep 4, 2024
There was a problem hiding this comment.
mavenLocal() comes with a bunch of drawbacks. In particular it slows down the build and it prevents Gradle from verifying that dependencies come from the "right" source (repository validations don't work).
I'd propose two changes here:
- Make the addition of
mavenLocal()dependent on a system or project property (example here). No need to slow down the build for everyone. - Use Gradle included builds - include the Iceberg build into the Polaris build. Then you also get all the benefits of Gradle and can skip the publishing step entirely. It also allows debugging into the Iceberg code.
|
@snazy thanks ! I will update the PR according to your comments. |
|
@snazy just to be sure, by "included builds", you mean using |
Either this - or in the build scripts - the result's the same |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.